HHH-18983 work on Generators #9496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return type.getName(); | ||
| } | ||
| return generatorConfig.strategy(); | ||
| return !Objects.equals( type, Generator.class ) ? type.getName() : generatorConfig.strategy(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
…enerators by letting value generators implement Configurable and ExportableProducer
gavinking
force-pushed
the
generator-cleanups-for7
branch
2 times, most recently
from
8a5fdf5 to
909f479
Compare
gavinking
force-pushed
the
generator-cleanups-for7
branch
from
909f479 to
f1d65e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows regular "value" (i.e. non-
@Id) generators to implementConfigurableandExportableProducer, finally putting them on equal footing with id generators.See https://hibernate.atlassian.net/browse/HHH-18983.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.